Skip to content

Feat project all#559

Merged
jpschorr merged 1 commit intomainfrom
feat-project-all
Apr 11, 2025
Merged

Feat project all#559
jpschorr merged 1 commit intomainfrom
feat-project-all

Conversation

@jpschorr
Copy link
Copy Markdown
Contributor

Make project-all work with the modeling of UNPIVOT


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested review from alancai98 and am357 April 10, 2025 22:49
@jpschorr jpschorr changed the base branch from main to fix-tuple-coerce-datum April 10, 2025 22:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2025

Conformance comparison report

Base (f998a55) d5f67ae +/-
% Passing 87.54% 87.54% 0.00%
✅ Passing 5777 5777 0
❌ Failing 822 822 0
🔶 Ignored 0 0 0
Total Tests 6599 6599 0

Number passing in both: 5777

Number failing in both: 822

Number passing in Base (f998a55) but now fail: 0

Number failing in Base (f998a55) but now pass: 0

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.06%. Comparing base (f998a55) to head (cda7037).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
partiql-logical-planner/src/lower.rs 93.75% 2 Missing ⚠️
...ion/partiql-extension-visualize/src/plan_to_dot.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   82.05%   82.06%   +0.01%     
==========================================
  Files         110      110              
  Lines       23243    23264      +21     
  Branches    23243    23264      +21     
==========================================
+ Hits        19072    19092      +20     
- Misses       3633     3634       +1     
  Partials      538      538              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from fix-tuple-coerce-datum to main April 11, 2025 16:58

#[test]
fn select_star_unpivot() {
let query = "SELECT * FROM UNPIVOT {'amzn': 840.05, 'tdc': 31.06} AS price AT sym";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be a good test we port to conformance tests

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpschorr jpschorr merged commit 7a613de into main Apr 11, 2025
19 checks passed
@jpschorr jpschorr deleted the feat-project-all branch April 11, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants