feat: allow GITHUB_BASE_URL as an env variable#40
Closed
armaandhull wants to merge 1 commit intopascalgn:mainfrom
armaandhull:main
Closed
feat: allow GITHUB_BASE_URL as an env variable#40armaandhull wants to merge 1 commit intopascalgn:mainfrom armaandhull:main
armaandhull wants to merge 1 commit intopascalgn:mainfrom
armaandhull:main
Conversation
armaandhull
commented
Jun 15, 2023
Author
armaandhull
left a comment
armaandhull
left a comment
There was a problem hiding this comment.
everything else is whitespace change due to mixed line endings in the file
Comment on lines
+32
to
+33
| // Set the GITHUB_BASE_URL constant value, using a default value of https://api.github.com if not provided | ||
| const GITHUB_BASE_URL = process.env.GITHUB_BASE_URL || "https://api.github.com"; |
Author
There was a problem hiding this comment.
declare the constant GITHUB_BASE_URL and use public Github api url as default value
| const pull_number = eventData.pull_request.number; | ||
|
|
||
| const octokit = new Octokit({ | ||
| baseUrl: GITHUB_BASE_URL, |
Author
There was a problem hiding this comment.
pass GITHUB_BASE_URL to Octokit constructor
Author
|
@pascalgn bumping this up |
Owner
|
@armaandhull Thanks for reminding me! I've decided to merge #43 instead because it had fewer changes and used GITHUB_API_URL, which is also used in https://github.com/pascalgn/automerge-action. Thanks for creating this PR and I hope your issue is still fixed now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #38