Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What doe
Fix broken undo/redo behavior across several move tools, and make the stair/roof move tool respect the root building's rotation.
Undo stack fixes
Six tools were writing preview state directly into the scene store during drag while
temporalwas paused, then resuming + writing the same final state on commit. Because the post-pause state already equalled the commit state, zundo had nothing to diff — undo became a no-op.Applied the same "restore-then-resume" pattern used by
use-draft-node.tsandmove-window-tool.tsx: while still paused, restore the original state; then resume, apply the final state, and pause again. This yields exactly one cleanoriginal → finalundo entry.Fixed in:
MoveWallTool— also combined position +isNewmetadata strip into a singleupdateNodesso it's one undo step.MoveWallEndpointToolCurveWallToolMoveSlabToolMoveCeilingToolHole editors (
SlabHoleEditor,CeilingHoleEditor) were checked and are already correct — they defer toPolygonEditor, which keeps the drag in local React state and only hits the store once per commit.Stair/roof building-rotation fix
MoveRoofTool(used for stair, stair-segment, roof, roof-segment) wrote world coordinates into the store and mesh during drag/commit for non-segment nodes. When the building had a rotation, the stair ended up offset and rotated incorrectly.