feat: nodes material system and bug fix#266
Merged
wass08 merged 9 commits intopascalorg:mainfrom Apr 20, 2026
Merged
Conversation
wass08
requested changes
Apr 20, 2026
Collaborator
wass08
left a comment
There was a problem hiding this comment.
Thank you! Need some changes before being merge-ready.
Also wasn't sure if having the material assignation in the renderer is better than in the system to prevent re-renders but we can keep it for now
| localPosition: [localPoint.x, localPoint.y, localPoint.z], | ||
| normal: e.face ? [e.face.normal.x, e.face.normal.y, e.face.normal.z] : undefined, | ||
| faceIndex: e.faceIndex ?? undefined, | ||
| materialIndex: getIntersectionMaterialIndex(e.object, e.faceIndex ?? undefined), |
Collaborator
There was a problem hiding this comment.
Pass the object in the event, and let the events needing this extra computation do it only when needed
| setMovingWallEndpoint: (value: MovingWallEndpoint | null) => void | ||
| curvingWall: WallNode | null | ||
| setCurvingWall: (wall: WallNode | null) => void | ||
| selectedWallMaterialTarget: SelectedWallMaterialTarget | null |
Collaborator
There was a problem hiding this comment.
could be replaced by selectedMaterialTarget with a generic type (and as we know the selected object we can deduct what type of node we're on) use AnyNodeId instead of roofNode['id'], wallNode['id']
Contributor
Author
There was a problem hiding this comment.
made the necessary changes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades the material system and interaction model across walls, stairs, roofs, and slabs by introducing multi-surface material support, click-targeted editing, and improved rendering stability.
It enables:
All updates are integrated into the existing architecture without introducing new state systems.
Walls
Stairs
uv2support for materials requiring secondary UVs.Roofs
Roof Materials
wood1,wood2,wood3to roof material picker.uv2support for final roof geometry and segments.Site / Ground Visuals
Fence UVs
Selection / Material Infrastructure
Slab Material Fix & Stability
Slider & Interaction Improvements
0.01mto0.1m.Cmd/Ctrl→0.01Shift→1