[-] fix panic for double unlock for unexpected method calls#216
[-] fix panic for double unlock for unexpected method calls#216pashagolub merged 2 commits intopashagolub:masterfrom
Conversation
Signed-off-by: Steve Coffman <steve@khanacademy.org>
|
Cool! Thanks! Would you please add a test case checking the bug. Thanks |
|
We have experienced similar behavior, specifically when running with We have tested this change and this does tackle the panic, and since all expectations are met due to the +1 from us! |
|
Thanks so much for merging! I was trying to circle back to write the tests, but mine were going to be way over complicated. :) |
|
Yeah, this one #217 was tricky to catch |
This PR avoids many double mutex unlock panics for unexpected calls to methods.
When the call to method was not expected, prior to this PR, pgxmock would not send the proper message back, but would instead panic without giving any message as to what the problem was.