[+] allow RowSet with error with no corresponding row#245
Merged
pashagolub merged 1 commit intopashagolub:masterfrom Oct 29, 2025
Merged
[+] allow RowSet with error with no corresponding row#245pashagolub merged 1 commit intopashagolub:masterfrom
RowSet with error with no corresponding row#245pashagolub merged 1 commit intopashagolub:masterfrom
Conversation
Allow a RowSet to be specified with an error row number that has no
corresponding row. Since the row returns an error, it seems unnecessary
for there to be a row.
In other words, rather than require something like:
NewRows([]string{"id", "title"}).
AddRow("one").
RowError(0, fmt.Errorf("error"))
In which both a row and a row error specify index 0, but the row is
never returned, allow omission of the row:
NewRows([]string{"id", "title"}).
RowError(0, fmt.Errorf("error"))
The pattern was broken in d07ccec, which checked only the number of rows
before closing a RowSet. Fix by having `Next` check both the length of
rows and whether an error is registered for the current row number. Add
a test for this case, as well.
theory
force-pushed
the
fix-one-row-error
branch
from
f1efd0d to
5ddb2e8
Compare
pashagolub
changed the title
RowSet with error with no corresponding row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a RowSet to be specified with an error row number that has no corresponding row. Since the row returns an error, it seems unnecessary for there to be a row.
In other words, rather than require something like:
In which both a row and a row error specify index 0, but the row is never returned, allow omission of the row:
The pattern was broken in d07ccec, which checked only the number of rows before closing a RowSet. Fix by having
Nextcheck both the length of rows and whether an error is registered for the current row number. Add a test for this case, as well.