Add local build caveats: name, version, and main in package.json#20
Open
chrisbolin wants to merge 1 commit intopastelsky:masterfrom
Open
Add local build caveats: name, version, and main in package.json#20chrisbolin wants to merge 1 commit intopastelsky:masterfrom
chrisbolin wants to merge 1 commit intopastelsky:masterfrom
Conversation
pastelsky
force-pushed
the
master
branch
14 times, most recently
from
bd82b40 to
ae5015f
Compare
Owner
|
I think we should handle cases where name / version might be I would consider this as a bug with our current implementation. Do you want to send a fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit some issues trying this locally, so I figured I add some clarification to the docs.
The error thrown when
versionwas not included:And no line-number was called out.