feat: Add runtime log level change support #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PakhomovAlexander
force-pushed
the
runtime-log-level-change
branch
2 times, most recently
from
8cc35bf to
02f06ec
Compare
PakhomovAlexander
force-pushed
the
runtime-log-level-change
branch
from
02f06ec to
ab9c5c0
Compare
Add LogLevelHandle that allows changing log level at runtime without service restart using tracing_subscriber::reload. - Add LogLevelHandle struct with set_level() method - Update setup_logs_with_rotation to return LogLevelHandle - Update all setup_logs variants to return the handle - Fix pre-existing clippy warnings (type complexity, format strings) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
PakhomovAlexander
force-pushed
the
runtime-log-level-change
branch
from
ab9c5c0 to
1a2f806
Compare
Handy-caT
reviewed
Jan 13, 2026
| .collect::<eyre::Result<_>>()?; | ||
|
|
||
| for (i, (reloader, filter)) in self.reloaders.iter().zip(filters).enumerate() { | ||
| reloader(filter).map_err(|e| eyre::eyre!("Failed to reload filter {i}: {e}"))?; |
Collaborator
There was a problem hiding this comment.
The only issue I see is this, like we can have situation when one layer is updated and second errored. Maybe it's correct way to have retry/rollback but I think it could be some overkill for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LogLevelHandlestruct that enables changing log level at runtime without service restarttracing_subscriber::reloadto wrapEnvFilterand provide dynamic reconfigurationLogLevelHandle(or tuple with existing return values forerror_aggregationfeature)Usage
API Changes
setup_logs_with_rotationreturns:error_aggregation:LogLevelHandleerror_aggregation:(LogLevelHandle, Arc<ErrorAggregationContainer>)setup_logsandsetup_logs_without_rotationTest plan
-D warnings🤖 Generated with Claude Code