Skip to content

Display improvements; migrate tests to Vitest#9

Merged
patik merged 16 commits into
mainfrom
display-improvements
Jun 1, 2025
Merged

Display improvements; migrate tests to Vitest#9
patik merged 16 commits into
mainfrom
display-improvements

Conversation

@patik
Copy link
Copy Markdown
Owner

@patik patik commented Jun 1, 2025

  • Fixes Fix grammar #8
  • Migrates tests to vitest
  • Add a loading spinner for each command
  • Just one line of output for each branch deletion attempt

Image

CleanShot.2025-06-01.at.19.22.01.mp4

@patik patik requested a review from Copilot June 1, 2025 18:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the branch deletion UX by adding per-branch loading spinners, streamlining the final output messages, and updating tests and retry logic to match the new messaging.

  • Introduces an ora spinner for each deleted branch and updates summary messages
  • Adjusts test scripts to align with the new output format
  • Refines retry logic messages and adds a top-level success message in the main program

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/utils/find-stale.ts Replaced gray console logs with an ora spinner and updated summary messages
src/tests/manual.ts Added a manual test helper script
src/tests/index.ts Updated import paths and assertions to reflect new output text
src/program/retryFailedDeletions.ts Tweaked the retry message formatting and getCountsText logic
src/program/index.ts Added a success message when no deletions fail
package.json Added ora dependency and updated test/lint script commands
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

src/tests/manual.ts:3

  • [nitpick] This manual test script lacks any assertions or validation, so it won't catch regressions. Consider converting it into an automated test with assertions or documenting its expected output.
function run() {

Comment thread src/utils/find-stale.ts Outdated
Comment thread src/utils/find-stale.ts
Comment thread src/program/retryFailedDeletions.ts
@patik patik changed the title Display improvements Display improvements and move to Vitest Jun 1, 2025
@patik patik marked this pull request as ready for review June 1, 2025 19:48
@patik patik changed the title Display improvements and move to Vitest Display improvements; migrate tests to Vitest Jun 1, 2025
@patik patik merged commit 3fb1dc2 into main Jun 1, 2025
3 checks passed
@patik patik deleted the display-improvements branch June 1, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix grammar

2 participants