Display improvements; migrate tests to Vitest#9
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the branch deletion UX by adding per-branch loading spinners, streamlining the final output messages, and updating tests and retry logic to match the new messaging.
- Introduces an ora spinner for each deleted branch and updates summary messages
- Adjusts test scripts to align with the new output format
- Refines retry logic messages and adds a top-level success message in the main program
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/find-stale.ts | Replaced gray console logs with an ora spinner and updated summary messages |
| src/tests/manual.ts | Added a manual test helper script |
| src/tests/index.ts | Updated import paths and assertions to reflect new output text |
| src/program/retryFailedDeletions.ts | Tweaked the retry message formatting and getCountsText logic |
| src/program/index.ts | Added a success message when no deletions fail |
| package.json | Added ora dependency and updated test/lint script commands |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
src/tests/manual.ts:3
- [nitpick] This manual test script lacks any assertions or validation, so it won't catch regressions. Consider converting it into an automated test with assertions or documenting its expected output.
function run() {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CleanShot.2025-06-01.at.19.22.01.mp4