Conversation
| postgres-types = { default-features = false, optional = true, package = "postgres-types", version = "0.2" } | ||
| proptest = { default-features = false, optional = true, features = ["std"], version = "1.0" } | ||
| rand-0_9 = { default-features = false, optional = true, package = "rand", version = "0.9" } | ||
| rocket = { default-features = false, optional = true, version = "0.5" } |
There was a problem hiding this comment.
Rocket can't be renamed, as its derive requires the standard crate name.
Note: rocket doesn't seem to have been updated in over a year and despite that (looking at the crate graph), most users are still on rc versions. I think we should consider removing support for it in v2.
| version-sync = { default-features = false, features = ["html_root_url_updated", "markdown_deps_updated"], version = "0.9" } | ||
|
|
||
| # Enable features for testing | ||
| rust_decimal = { path = ".", features = ["rand-0_9", "macros", "tokio-pg", "rocket-0_5-traits"] } |
There was a problem hiding this comment.
Let me know if you don't like this, but it saves copying the same versions of everything again. Note that it doesn't work for crates like rand where we use additional features for testing.
| } | ||
|
|
||
| #[cfg(feature = "postgres")] | ||
| #[cfg(feature = "db-postgres")] |
There was a problem hiding this comment.
There is no postgres feature. I took a guess at what this was supposed to be, but haven't validated it.
| rand-0_9 = { default-features = false, optional = true, package = "rand", version = "0.9" } | ||
| rocket = { default-features = false, optional = true, version = "0.5" } | ||
| rust_decimal_macros = { path = "macros", default-features = false, optional = true, version = "1" } | ||
| rkyv = { default-features = false, features = ["size_32", "std"], optional = true, version = "0.7.42" } |
There was a problem hiding this comment.
We have an example on how to integrate against rkyv 0.8. I don't think our v2 needs to support rkyv 0.7.
| borsh = { default-features = false, features = ["derive", "unstable__schema"], optional = true, version = "1" } | ||
| bytes = { default-features = false, optional = true, version = "1" } | ||
| diesel = { default-features = false, optional = true, version = "2" } | ||
| ndarray-0_16 = { default-features = false, optional = true, package = "ndarray", version = "0.16" } |
There was a problem hiding this comment.
Calling out the version bump from 0.15 to 0.16
Tony-Samuels
force-pushed
the
standardise-deps
branch
3 times, most recently
from
db5ee58 to
d7662ef
Compare
|
Sorry for the delay in review - can you resolve the conflicts and I can take a look again? |
Tony-Samuels
force-pushed
the
standardise-deps
branch
from
d7662ef to
0b1bc18
Compare
# Conflicts: # Cargo.toml # src/decimal.rs # src/rand_0_9.rs
2 participants
No description provided.