Merged
Conversation
Owner
|
I think what you're trying to achieve is right - I think for this PR you just need to take the arguments outside of the |
Adds two new public methods on Decimal: - as_i128(): infallible equivalent of ToPrimitive::to_i128() - as_f64(): infallible equivalent of ToPrimitive::to_f64() The existing ToPrimitive methods now delegate to these. Fixes: move methods to impl Decimal (not inside impl ToPrimitive) Fixes: stray semicolon causing as_f64() to not return in scale==0 branch Fixes: leftover Some() wrappers in as_f64() body Closes paupino#727
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#727
Sorry, I know this is failing. Haven't had the chance to build it. Will put the function in the right place when I get a chance.
But will take a look. Was just a demo