Support scientific notation in Decimal::from_str()#781
Merged
Conversation
paupino
force-pushed
the
fix/753-v2-scientific-from-str
branch
from
eb1b9aa to
cca4a84
Compare
On error from parse_str_radix_10, check for 'e'/'E' and dispatch to from_scientific_lossy. Zero overhead on the happy path — benchmarks show no regression for standard decimal parsing. Fixes #722. Co-authored-by: kofki <69553679+kofki@users.noreply.github.com>
paupino
force-pushed
the
fix/753-v2-scientific-from-str
branch
from
cca4a84 to
b84da21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for parsing scientific notation (e.g.
1.23e4,6.7E-1) directly viaDecimal::from_str().Approach
On error from
parse_str_radix_10, checks fore/Ein the input and dispatches tofrom_scientific_lossy. This ensures zero overhead on the happy path - benchmarks show no regression for standard decimal parsing (~73ns before and after).Alternative approaches considered:
contains: ~2x regression (73ns -> 154ns) due to redundant byte scanningTests
Added tests for: positive exponent, negative exponent, uppercase
E, negative value with scientific notation, and zero exponent.Fixes #722. Based on the original work by @kofki in #753.