Fix the compiler suggesting unimplemented variables#374
Fix the compiler suggesting unimplemented variables#374YashasSamaga merged 2 commits intopawn-lang:devfrom
Conversation
|
not related specifically to this PR but to the system There is an The previous version of the compiler was giving out errors instead of an assertion failure. |
|
I have wished you could take the tag of literals a few times:
Not obviously useful as typed, but is in macro outputs. But I have macros to remove anything after the |
|
Ok, I fixed this and a couple of other bugs locally. Would it be alright if I turn this PR into a more general one and upload those bugfixes here? (Just asking because this PR has already been approved in the current state.) |
|
No, make those a separate pull request. The point of approvals is to show that the code's been checked, adding more after that defeats the purpose. |
|
Well, I wasn't asking this only because this PR has already been approved, but also because uploading those fixes in a separate PR would definitely lead to a mess with merge conflicts, but ok. |
|
I think every new feature should have a corresponding issue. I couldn't find an issue for this system which is why I sneaked it in here. I could have made an issue instead of commenting it here though. |
What this PR does / why we need it:
This PR fixes the problem where after the 1'st pass the compiler suggests global variables before the point of their definition:
Which issue(s) this PR fixes:
What kind of pull this is:
Additional Documentation: