pawndisasm: Minor fixes, code cleanup#424
Merged
Zeex merged 5 commits intopawn-lang:devfrom Jun 15, 2019
Merged
Conversation
…'code' being leaked on errors
Contributor
|
👍 |
Zeex
approved these changes
Jun 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed input and output files not being properly closed and
codebeing leaked on early returns.Implemented proper handling for invalid instructions.
Now instead of crashing on invalid instructions (due to OOB access to the opcode table)
pawndisasmprints a proper error message with the code of invalid instruction and the address it was detected at.Removed extra space after AMX flags.
Code cleanup.
It seems that the opcode table was copied from
sc6.cand sorted by opcode IDs instead of alphabetical order, but fieldOPCODE::opcodewas left unused.do_switch()(it was a duplicate ofdo_jump()).casetbl()has been renamed intodo_casetbl()to be more in-line with the names of the other opcode handlers.Which issue(s) this PR fixes:
What kind of pull this is:
Additional Documentation: