Draft
Conversation
KunJeongPark
reviewed
Apr 7, 2025
| if (updateConfigResult is UpdateClientConfigResult.Failure) { | ||
| // notify failure | ||
| callback.onPayPalWebStartResult( | ||
| PayPalPresentAuthChallengeResult.Failure(updateConfigResult.error) |
Contributor
There was a problem hiding this comment.
Have we decided to return failure upon failure on this GraphQL call?
I know JS SDK does not do that atm and Ravi had mentioned that this is probably what should be done.
Collaborator
Author
There was a problem hiding this comment.
I don't think we've made a decision on this. I'd be curious to know how failure affects the overall transaction before making the final call.
sshropshire
force-pushed
the
bcdc-paypal-payments
branch
from
54e5834 to
080a552
Compare
1 task
…sdk." This reverts commit d7d02aa.
sshropshire
force-pushed
the
bcdc-paypal-payments
branch
from
d48f356 to
ec73f11
Compare
1 task
linetterobinson01-design
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
:PayPalWebPaymentsmoduleChecklist
Authors