Skip to content

Fix misleading indentation#233

Open
dveeden wants to merge 1 commit intoperl5-dbi:masterfrom
dveeden:misleading_indent
Open

Fix misleading indentation#233
dveeden wants to merge 1 commit intoperl5-dbi:masterfrom
dveeden:misleading_indent

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Feb 9, 2026

dbdimp.c: In function ‘mariadb_db_login6_sv’:
dbdimp.c:2675:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
 2675 |   if (!mariadb_db_my_login(aTHX_ dbh, imp_dbh))
      |   ^~
In file included from dbdimp.h:42,
                 from dbdimp.c:16:
/usr/lib64/perl5/vendor_perl/auto/DBI/DBIXS.h:324:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  324 |     do {                                                                \
      |     ^~
dbdimp.c:2681:5: note: in expansion of macro ‘DBIc_ACTIVE_on’
 2681 |     DBIc_ACTIVE_on(imp_dbh);
      |     ^~~~~~~~~~~~~~

@choroba
Copy link
Member

choroba commented Feb 9, 2026

The failed tests are caused by GitHub's infrastructure problems. I'll try to rerun them once GitHub gets stable.

@choroba choroba added the Rerun tests Tests failed for some external reasons, rerun them later. label Feb 9, 2026
@dveeden
Copy link
Contributor Author

dveeden commented Feb 27, 2026

@choroba did you re-run them?

@choroba
Copy link
Member

choroba commented Feb 27, 2026

GH Action tests are all green now. FreeBSD has problems, but that's because our tests need to move to a more recent version.

@choroba
Copy link
Member

choroba commented Feb 27, 2026

Once the fix to the FreeBSD tests is merged, we need to rebase this PR's branch to it and the tests will run.

@choroba
Copy link
Member

choroba commented Feb 27, 2026

FreeBSD tests should be ready.

@dveeden
Copy link
Contributor Author

dveeden commented Feb 27, 2026

I've rebased my commit on master

@choroba choroba removed the Rerun tests Tests failed for some external reasons, rerun them later. label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants