Support a wider array of integers #3084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinistersnare
force-pushed
the
bugfix/more-arrow-integers
branch
from
0eeabb5 to
c9a23cd
Compare
Signed-off-by: Davis Silverman <[email protected]>
sinistersnare
force-pushed
the
bugfix/more-arrow-integers
branch
from
c9a23cd to
7051bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently arrow files may be sent to Perspective that use a variety of integer types that are not supported internally by Perspective. This PR allows these types by properly handling them on the server-side.
Look at the provided test to generate the appropriate arrow that fails on
masterbut passes on this branch.