Skip to content

Conversation

@peterramsing
Copy link
Owner

What kind of change is this? (Bug Fix, Feature...)
Bugfix

What is the current behavior (You can also link to an issue)
Closes #370

What is the new behavior this introduces (if any)
Adds max-width to Waffle Grids

Does this introduce any breaking changes?
Shouldn't

Does the PR fulfill these requirements?

  • Tests for the changes have been added
    - [ ] Docs have been added or updated

Other Comments
Issue #370

@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #406 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #406   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines         701    701           
=====================================
  Hits          701    701
Impacted Files Coverage Δ
lib/lost-waffle.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7681e79...b04ead9. Read the comment docs.

@peterramsing
Copy link
Owner Author

Crumbs. CodeClimate really doesn't like this PR. It says the file is too long. I'm not sure if that's worth fixing right now... 🤔

@peterramsing
Copy link
Owner Author

peterramsing commented Mar 17, 2018

@codebysubtract, feel like giving this a glance to
1. See if I really should address the CodeClimate issue Self-resolved
2. Double check my semver
3. Does this fix cause any concern for regressions?

@steve-holland
Copy link
Contributor

@peterramsing

  1. It feels like more than a Patch, but in the strict definition it is a bug fix, not really new functionality I guess. So I think Patch is fine.
  2. Not as far as I can see. Code looks good, test coverage seems to be taken care of, so all good on that front.

@peterramsing peterramsing merged commit b64c29d into master Jun 12, 2018
@peterramsing peterramsing deleted the 370_max-width branch June 12, 2018 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect column widths in Firefox

3 participants