Add norm-p as distance metric (with positive real p)#160
Merged
xgdgsc merged 3 commits intopeterwittek:masterfrom Jun 14, 2021
Merged
Add norm-p as distance metric (with positive real p)#160xgdgsc merged 3 commits intopeterwittek:masterfrom
xgdgsc merged 3 commits intopeterwittek:masterfrom
Conversation
…norm in the input vector space, with arbitrary positive real p, or norm-inf norm-p is currently supported only with kerneltype=0, so initialization fails with error if norm-p is required with a different kerneltype
xgdgsc
requested changes
Jun 13, 2021
…at p is positive if norm-p is specified
Collaborator
|
Thamks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the option to provide as vect_distance strings like "norm-3", "norm-6", "norm-2" (same as the default) and "norm-inf", besides "euclidean" when creating the SOM (norm-p with any positive real p). For example:
This is supported with kerneltype = 0 only, at the moment (the GPU kernel uses an optimized implementation tied to p=2, but in the future it might be possible to add in denseGpuKernels.cu, alongside the current implementation, an alternate one if norm-p is specified).