Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes time-dependent tests by introducing a mockable time function. The change allows tests to use archived DNS fixture data with DNSSEC signatures that would otherwise expire over time.
Changes:
- Introduced a
nowFuncvariable insignedzone.gothat defaults totime.Nowbut can be overridden in tests - Replaced direct
time.Now()call withnowFunc()in DNSSEC signature validation - Added
TestMaininmain_test.goto set a fixed time (March 15, 2019) for all tests, ensuring RRSIG records in fixture data remain valid
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| signedzone.go | Added nowFunc variable and updated RRSIG validity check to use it instead of time.Now() |
| main_test.go | Added TestMain to override nowFunc with a fixed date within the validity period of archived DNSSEC signatures |
| lookup_test.go | Minor whitespace formatting change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
superseded by #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nowFuncvariable so tests can set the current timenowFuncin tests so archived DNS fixtures remain validTesting
go test ./...(fails: Get "https://proxy.golang.org/...": Forbidden)https://chatgpt.com/codex/tasks/task_e_685c886fb510833196ec8fbfb4ee596a