Skip to content

Fix isort_wrapper to recognize first party correctly #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drafear wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix isort_wrapper to recognize first party correctly #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pysen/ext/isort_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def run(
if len(targets) == 0:
return 0

cmd = ["isort", "--settings-path", str(setting_path)]
cmd = ["isort", "--settings-path", str(setting_path), "--src", str(base_dir)]
Copy link
Copy Markdown
Member

@Hakuyume Hakuyume Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isort==4 does not seem to support --src option. We may need to check isort's version in the same manner to --recursive option.

Copy link
Copy Markdown
Member

@Hakuyume Hakuyume Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base_dir may not what you want. it is not the source directory.

if version.major == 4:
cmd.append("--recursive")
if not inplace_edit:
Expand Down