Support --features trusted on macOS#334
Merged
eeeebbbbrrrr merged 2 commits intodevelopfrom Jun 14, 2023
Merged
Conversation
With this PR, PL/Rust now supports installation as a Trusted Procedural Language on macOS. It also supports cross compiling between x86_64 and aarch64 on macOS. We do **NOT** support cross-compiling between operating systems.
thomcc
approved these changes
Jun 12, 2023
Contributor
thomcc
left a comment
thomcc
left a comment
There was a problem hiding this comment.
Looks great. No objections -- the weird bits are non-public and this is much simpler than the alternative.
| "postgres" | ||
| cfg_if::cfg_if! { | ||
| if #[cfg(target_vendor = "apple")] { | ||
| "apple-darwin" |
Contributor
There was a problem hiding this comment.
Not exactly the vendor (more like vendor-os) but eh, doesn't matter much.
| }} | ||
| cfg_if::cfg_if! { | ||
| if #[cfg(all(feature = "trusted", target_os = "macos"))] { | ||
| const OS: &str = "postgres"; |
Contributor
There was a problem hiding this comment.
Definitely not the OS. This one is a little silly, but these aren't pub so whatever.
Contributor
Author
|
Thanks for making CI work on macOS, @BradyBonnette |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, PL/Rust now supports installation as a Trusted Procedural Language on macOS.
It also supports cross compiling between x86_64 and aarch64 on macOS.
We do NOT support cross-compiling between operating systems.