Skip to content

Drop old tempdir dep#357

Merged
workingjubilee merged 1 commit intopgcentralfoundation:developfrom
workingjubilee:update-to-tempfile
Jul 14, 2023
Merged

Drop old tempdir dep#357
workingjubilee merged 1 commit intopgcentralfoundation:developfrom
workingjubilee:update-to-tempfile

Conversation

@workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Jul 13, 2023

tempfile provides functions for tempdirs too,
so we do not need an old, deprecated dep.
This also gets rid of a minor dependabot advisory,
not actually exploitable in our usage.

@workingjubilee workingjubilee requested a review from thomcc July 13, 2023 23:21
tempfile provides functions for tempdirs too,
so we do not need an old, deprecated dep.
This also gets rid of a minor security advisory,
not actually exploitable in our usage.
@workingjubilee
Copy link
Member Author

@workingjubilee You have to actually run cargo test in order to check if tests compile, Jubilee, you can't get away with a quick cargo check unless it is cargo check --tests.

@workingjubilee workingjubilee merged commit ade8891 into pgcentralfoundation:develop Jul 14, 2023
@workingjubilee workingjubilee deleted the update-to-tempfile branch July 14, 2023 00:05
@workingjubilee workingjubilee mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants