Change plrust.allowed_dependencies to sighup context#362
Merged
eeeebbbbrrrr merged 2 commits intopgcentralfoundation:developfrom Jul 21, 2023
Merged
Conversation
Contributor
|
This looks good but does require documentation updates. @anth0nyleung if you don't have time/desire to also do those, that's fine -- we'll take care of it after we merge. I'm really noting it so that it doesn't get forgotten. |
Contributor
Author
|
@eeeebbbbrrrr Thanks for review. I have also updated the documentation for the guc. Please feel free to edit further if necessary. |
eeeebbbbrrrr
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there is no technical reason l to set
plrust.allowed_dependenciestoPostmastercontext which requires engine restart to change its value, we can change its context tosighupsuch that the guc can be modified dynamically to provide more flexibility when using allowlisted crates.Testing
/tmp/old.toml/tmp/new.toml