Some revisions to the idea of using a function#21
Merged
pgomulka merged 3 commits intopgomulka:xpack-spi-requestfrom Jul 29, 2020
Merged
Some revisions to the idea of using a function#21pgomulka merged 3 commits intopgomulka:xpack-spi-requestfrom
pgomulka merged 3 commits intopgomulka:xpack-spi-requestfrom
Conversation
pgomulka
reviewed
Jul 29, 2020
| Pattern.CASE_INSENSITIVE); | ||
|
|
||
| @Override | ||
| public Version getCompatibleVersion(@Nullable String acceptHeader, @Nullable String contentTypeHeader) { |
Owner
There was a problem hiding this comment.
it does look better than the logic we had before. Lack of hasContent() makes it look cleaner, but makes the validation less strict. I will add previous test cases to verify
| "Accept=%s Content-Type=%s", acceptHeader, | ||
| contentTypeHeader)); | ||
| } | ||
| return Version.fromString(Version.CURRENT.major - 1 + ".0.0"); |
Owner
There was a problem hiding this comment.
I think we might be missing previous test case when someone is using a compatible api but his client is not sending accept and content-type headers. Looks like it is possible ?
| public RestController(Set<RestHeaderDefinition> headersToCopy, UnaryOperator<RestHandler> handlerWrapper, | ||
| NodeClient client, CircuitBreakerService circuitBreakerService, UsageService usageService, | ||
| BiFunction<Map<String, List<String>>, Boolean, Boolean> isRestCompatibleFunction) { | ||
| BiFunction<String, String, Version> restCompatibleFunction) { |
Owner
There was a problem hiding this comment.
This BiFunction and just types makes me worried that this will become less readable.
I wonder if we can create an interface for it. Will give it a go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.