Improve faulty parsing: rename content as contents (a s was missing)#12854
Merged
MarcusDenker merged 5 commits intopharo-project:Pharo11from Feb 27, 2023
Merged
Conversation
Member
|
There is now a merge conflict |
…arsing-bad-content
Contributor
Author
|
I did a merge to solve a conflict likely introduced by Iceberg when it moved code around :( |
Member
|
tests in RBCodeSnippetTest are failing (I think it uses the #content method) |
MarcusDenker
added
the
Status: Need more work
MarcusDenker
removed
the
Status: Need more work
MarcusDenker
approved these changes
Feb 27, 2023
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The English language is weird (syntax doesn't even fit on a postcard...)
Note the impact of such a small letter change was larger than I expected (and having a styler that semi randomly signals MNU while editing is not fun)