Rewrite some error messages to follow the style Foo expected#12874
Merged
MarcusDenker merged 2 commits intopharo-project:Pharo11from Feb 28, 2023
Merged
Conversation
MarcusDenker
approved these changes
Feb 28, 2023
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format
Foo expected(with an uppercase, no article and no verb) is used on almost all error messages. This PR changes some noncompliant ones.Also, on
| expected,varableorparameterare added, because they are also expected, and because it helps to understand the context.Note: this PR might conflict with #12868, so merge the other before.
You might consider reviewing this one in the meantime.