Improve faulty parsing of methods#12879
Merged
MarcusDenker merged 14 commits intopharo-project:Pharo11from Mar 1, 2023
Merged
Conversation
…ods it becomes a mess)
Contributor
Author
|
Merge with P11 to solve conflict with #12868 (I initially thought that both PR were not conflictual) |
this line was dropped during some rebasing
MarcusDenker
approved these changes
Mar 1, 2023
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a little larger than the previous one but it's mainly small commits.
Note: I do not change the compiler behavior when dealing with faulty AST. Especially, no RuntimeSyntaxicError is signaled is the method contains buggy pragmas or parameters. But maybe it's not the job of the compiler to do such policy decision about what faulty code is acceptable to execute or not?