add RBCodeSnippetTest>>#testCodeImporter#12933
Merged
MarcusDenker merged 4 commits intopharo-project:Pharo12from Mar 16, 2023
Merged
add RBCodeSnippetTest>>#testCodeImporter#12933MarcusDenker merged 4 commits intopharo-project:Pharo12from
MarcusDenker merged 4 commits intopharo-project:Pharo12from
Conversation
Contributor
Author
|
Errors seems related to #12935 . Merge this other one and rerun the tests |
Contributor
Author
|
PR #12995 was merged and now the test are OK (except random windows weirdness) |
MarcusDenker
approved these changes
Mar 16, 2023
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends RBCodeSnippetTest to test CodeImporter
CodeImporter is a client of OpalCompiler and might be confronted to faulty code.
This PR does not change the behavior of the importer (just add test). Therefore, compilation errors are expected to be produced on faulty code.
In classical use, such compilation errors are caught by the buggy SyntaxErrorDebugger. But the present test only check (and capture) the SyntaxErrorNotification signals, and does not check the recoverability. See #12910 for related rants.
The test is a little complex because there are basically two modes, one for expressions and one for methods, and we need a placeholder class and to retrieve the method in the latter.
Note: I do not know how much the CodeImporter is used in real life.