Skip to content

Faulty compiler: new CodeError class#13029

Merged
MarcusDenker merged 10 commits intopharo-project:Pharo12from
privat:faulty-compiler-codeerror
Mar 17, 2023
Merged

Faulty compiler: new CodeError class#13029
MarcusDenker merged 10 commits intopharo-project:Pharo12from
privat:faulty-compiler-codeerror

Conversation

@privat
Copy link
Contributor

@privat privat commented Mar 16, 2023

This PR adds a new error super class for syntactic and semantic errors: CodeError.

The changes are rather brutal since:

  • SyntaxErrorNotification become an Error (instead of a notification). The name stays unchanged for now.
  • OCSemanticError is stripped of its responsibility to report error on the UI (yes, it was this bad).

Note: OCSemanticWarning, especially OCUndeclaredVariableWarning are let untouched (yet!)

Let's see if CI thinks this to too much change to handle...

@privat
Copy link
Contributor Author

privat commented Mar 16, 2023

tests are ok, except windows. But I added more commits for some related cleanup

@MarcusDenker MarcusDenker merged commit 22471b2 into pharo-project:Pharo12 Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants