CodeImport - stop requestor madness#13162
Merged
MarcusDenker merged 2 commits intopharo-project:Pharo12from Mar 28, 2023
Merged
CodeImport - stop requestor madness#13162MarcusDenker merged 2 commits intopharo-project:Pharo12from
MarcusDenker merged 2 commits intopharo-project:Pharo12from
Conversation
Contributor
Author
|
Ouch, I'm not sure what I broke, but I broke it hard. |
Contributor
Author
|
Retry CI is case of a transient issue |
78 tasks
MarcusDenker
approved these changes
Mar 28, 2023
Member
|
I think this (loading .st files) is the use-case that it is supposed to support. So with tests green this is good to merge |
Member
|
MarcusDenker
added
the
Status: Need more work
Member
|
I never liked this request or thing. It’s great to see it been removed. IMO this was complicating the compilation while it was not it’s responsibility |
Contributor
Author
|
Requestors are bad, the plan is to remove them #12883 |
privat
removed
the
Status: Need more work
MarcusDenker
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This remove made-up requestors in CodeImport
Tests seems ok (but tests might be lacking).
I also tried to drag-n-drop various
.stfiles with various level of brokenness and things seems working.In case of syntax error, you get the code error exception. You can close the window (and installation is aborted) or you can proceed, that installs faulty methods. Then you can fix the method on your own time.
@MarcusDenker Is there some use cases I'm missing?