Remove RBInstanceVariableNode crufts#13199
Merged
MarcusDenker merged 2 commits intopharo-project:Pharo12from Mar 30, 2023
Merged
Remove RBInstanceVariableNode crufts#13199MarcusDenker merged 2 commits intopharo-project:Pharo12from
MarcusDenker merged 2 commits intopharo-project:Pharo12from
Conversation
jecisc
approved these changes
Mar 30, 2023
Member
jecisc
left a comment
jecisc
left a comment
There was a problem hiding this comment.
Before we had multiple AST variable nodes. Now we only have one that knows its binding. This was indeed a leftover :)
Contributor
Author
|
CI ok, windows error unrelated |
jecisc
added
Status: Reviewed and Ready to Integrate
and removed
Status: Tests passed please review!
labels
MarcusDenker
approved these changes
Mar 30, 2023
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13189 shows that some leftover from a presumably removed class RBInstanceVariableNode remains, and was not detected because used in an evaluated string — eval is evil :)
Some method
visitInstanceVariableNode:did still exist with a parameter namedaRBInstanceVariableNodebut I think they are still used viaSlot>>#acceptVisitor:node:. I'm not sure, so I do not touch