Faulty code snippet: test evaluation#13223
Merged
MarcusDenker merged 6 commits intopharo-project:Pharo12from Mar 31, 2023
Merged
Faulty code snippet: test evaluation#13223MarcusDenker merged 6 commits intopharo-project:Pharo12from
MarcusDenker merged 6 commits intopharo-project:Pharo12from
Conversation
MarcusDenker
approved these changes
Mar 31, 2023
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluation of random strings (the evil eval) can be performed with
OpalCompiler evaluate: aString.CodeSnippet did not have tests to check it, it is now done.
Because only scripts can be evaluated (not method definitions), a subclass
RBCodeSnippetScriptingTestis created that matrix tests only on scripts.Some cleanup is performed on RBCodeSnippet. Especially, a new method
testExecuteBlock:to factorize the execution and check of a snippet byproduct.