Cleanup some compiler clients#13235
Merged
MarcusDenker merged 7 commits intopharo-project:Pharo12from Apr 1, 2023
Merged
Conversation
privat
force-pushed
the
cleanup-some-compiler-clients
branch
from
2429f6a to
fc03573
Compare
78 tasks
MarcusDenker
approved these changes
Apr 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pharo11 and (current) Pharo12 and probably older versions of Pharo offers a failBlock on OpalCompiler.
But it is required if there is a requestor, and ignored otherwise.
So a failBlock without a requestor (or in faulty mode) is just dead code that can be removed.
This PR do some cleanup to remove unused failBlock (possible cruft).
It also removes the requestor of Monticello MethodAddition that is always nil