Faulty code: move code reparator to RBNotice#13277
Merged
MarcusDenker merged 7 commits intopharo-project:Pharo12from Apr 5, 2023
Merged
Faulty code: move code reparator to RBNotice#13277MarcusDenker merged 7 commits intopharo-project:Pharo12from
MarcusDenker merged 7 commits intopharo-project:Pharo12from
Conversation
… non-interactive mode
Contributor
Author
|
test ok, issues unrelated. cf #13278 |
jecisc
reviewed
Apr 4, 2023
MarcusDenker
approved these changes
Apr 5, 2023
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a simple cleanup, but I do not like big PR.
The original idea was to simplify
OpalCompiler >> checkNotice:by removing conditions and type checks.A simple solution was to move the reparation concern to the RBNotice.
Currently, OCCodeReparator is still the fragile and limited class that was extracted from the original OCUndeclaredVariableWarning, but there is no reason that clients have to deal with too much detail about that.
So let's imagine that any RBNotice might propose some possible ways to repair itself. It simplifies the client code that do not have to deal about specific errors and warnings.