Vocabulary: propose "script" in compiler#13301
Merged
MarcusDenker merged 7 commits intopharo-project:Pharo12from Apr 20, 2023
Merged
Vocabulary: propose "script" in compiler#13301MarcusDenker merged 7 commits intopharo-project:Pharo12from
MarcusDenker merged 7 commits intopharo-project:Pharo12from
Conversation
Member
|
Workspace is the ancestor of the playground. I don’t like #noPattern either and prefer what you proposed. I like the “scripting” vocabulary! |
jecisc
approved these changes
Apr 6, 2023
Member
|
Yes script or snippet is good. It would be good to effectively clean all the API because this is confusing in many places. |
MarcusDenker
approved these changes
Apr 6, 2023
Member
MarcusDenker
left a comment
There was a problem hiding this comment.
Yes, it is good to unify the terms. Both "notPattern" and "Workspace" are not good. "script" is nice (and we use it already in some places)
Member
|
There is now a conflict |
78 tasks
Contributor
Author
|
I did a rebase with improvements:
|
Contributor
Author
|
Tests are green, please review |
MarcusDenker
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpalCompiler>>noPatternis historic and bad:`and@to match AST (in rewriting tools for instance)I tried to look at various parts of the Pharo tools to see what is the used vocabulary.
RBParseruseexpression, like inparseExpressionThat is ok but misleading since sequences of statements (|x| x:=self. x bar) or return statements (^ 42) are parsed the same but technically aren't expressions. See Parse expression should never return a sequence node #7233ExpressionEvaluatedis aSystemAnnouncementused when someone runs a DoIt (or other action). (I do not understand why you need to announce them, but it's not the focus here)CodeImportuseDoIt, like inDoItChunk. That is better thannoPatternbut maybe too specific?isScripting, orbeForScriptingI kind of like it (see title)Monticellousescript, like inMCScriptDefinitionand relatedMetacelloseems to useDoIt, as inpreLoadDoItSHRBTextStylerhaveisForWorkspace, that can be used to highlight source code outside the workspace :) and seems the only one to use "workspace" this way.playgroundseems not usedscript:is also a pragma, that takes a string to evaluateSince I'm cleaning up the compiler API, I would like to have your input.
And if nobody cares, I will go ahead with "script".
The commit is a simple preview of what it might look like.