Compiler simplify OCSemanticScope#13303
Merged
MarcusDenker merged 4 commits intopharo-project:Pharo12from Apr 6, 2023
Merged
Conversation
Contributor
Author
|
jecisc
approved these changes
Apr 6, 2023
Member
jecisc
left a comment
jecisc
left a comment
There was a problem hiding this comment.
This seems easier to read indeed
| anObject ifTrue: [ | ||
| semanticScope := semanticScope asDoItScope. | ||
| "when we compile an expression, embedd sources, as the resulting method will never be installed" | ||
| self parseOptions: #(+ #optionEmbeddSources). |
Member
There was a problem hiding this comment.
Is this parse option removal intended?
Contributor
Author
There was a problem hiding this comment.
Yep, it is wrongly placed and duplicates one that is correctly placed: https://github.com/pharo-project/pharo/blob/Pharo12/src/OpalCompiler-Core/OpalCompiler.class.st#L335
MarcusDenker
approved these changes
Apr 6, 2023
Member
|
there is no a conflict |
jecisc
added
Status: Reviewed and Ready to Integrate
and removed
Status: Tests passed please review!
Status: Merge conflict
labels
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class hierarchy
OCSemanticScopeis used to abstract the contextual semantic of a source code: method definition, basic script, or advanced script in a context (for debugger).For some reason, the current code is far more complex than required. This PR tries to simplify it.