ASTCache>>#at:put: prevent TOCTOU when cleaning the cache#13408
Merged
MarcusDenker merged 1 commit intopharo-project:Pharo12from Apr 12, 2023
Merged
ASTCache>>#at:put: prevent TOCTOU when cleaning the cache#13408MarcusDenker merged 1 commit intopharo-project:Pharo12from
MarcusDenker merged 1 commit intopharo-project:Pharo12from
Conversation
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some recent CI builds randomly fail on ASTCache.
The culprit is likely the cleaning. GC executions during the iteration can retire elements. So just ignore absent keys and be happy.