Skip to content

Can commit faulty code? #13424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
privat wants to merge 3 commits into from
Closed

Can commit faulty code? #13424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b10eeae
commit faulty code
privat Apr 13, 2023
91aa215
EpiceaBrowsers: stop catching all errors
privat Apr 13, 2023
c3c0dea
tonel break
privat Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/EpiceaBrowsers/EpLogBrowserOperationFactory.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,14 @@ EpLogBrowserOperationFactory >> events [
EpLogBrowserOperationFactory >> handleErrorDuring: aBlock [
"TODO: do not catch *all* Errors.
This error handler exists as a workaround to skip any unexpected error when applying or reverting a code change from GUI.
For example, when user reverts the protocol addition of a protocol that is already not present, and such action signals an unexpected error. The error in such case should be avoided via testing API."

aBlock
on: Error
do: self errorHandlerBlock
For example, when user reverts the protocol addition of a protocol that is already not present, and such action signals an unexpected error. The error in such case should be avoided via testing API.

Rebutal: If you silent all errors, you will never fix the one you can fix, and you will silently ignore the ones that the user need to catch.
"

aBlock value
" on: Error
do: self errorHandlerBlock"
]

{ #category : #private }
Expand Down
4 changes: 4 additions & 0 deletions src/OpalCompiler-Tests/OpalCompilerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ Class {
#category : #'OpalCompiler-Tests-Misc'
}

{ #category : #error }
OpalCompilerTest >> faultySource [ ^ 1+]
]

{ #category : #'tests - bindings' }
OpalCompilerTest >> testArrayBindingsWithUppercaseNameDoOverwriteGlobals [
| result |
Expand Down