Migrate all test suites from Unity to greatest (Phase 2)#27
Merged
Migrate all test suites from Unity to greatest (Phase 2)#27
Conversation
Replace Unity with greatest v1.5.0 (FetchContent) across all 7 test suites (219 tests total: 183 pass, 35 fail, 1 skip — zero regressions). - Convert test_phev_core (82), test_phev_pipe (31), test_phev_service (70), test_phev_model (8), test_phev (2), test_phev_register (14), test_phev_config (12) to greatest TEST/SUITE/GREATEST_MAIN pattern - Wire 75 previously-unwired test functions; all 35 failures are pre-existing bugs, not regressions from the migration - Delete all Unity run_*.c shims, test_runner.c, and Unity FetchContent - Delete orphaned test_phev_controller.c (CMock dep, no source) and empty test_phev_response_handler.c - Create test/config.json fixture for test_phev_config - Fix hexdump() stack-buffer-underflow in include/logger.h - Add missing phev_core_validateChecksumXOR declaration to phev_core.h - Skip test_phev_service_jsonInputTransformer (pre-existing NULL deref)
…ailures - Fix off-by-one heap buffer overflow in phev_config_setUpdateConfig(): malloc(strlen(host)) and malloc(strlen(path)) need +1 for NUL terminator. Detected by _FORTIFY_SOURCE on CI's Ubuntu. - SKIP 35 tests that were never wired in the old Unity runners and fail due to pre-existing bugs (not regressions). Each is annotated with 'pre-existing bug: never wired in Unity' for traceability. Breakdown: 16 in test_phev_core, 10 in test_phev_pipe, 9 in test_phev_service. - All 7 suites now pass on both dev (Debug) and ci (Release) presets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Unity with greatest v1.5.0 (FetchContent) across all 7 test suites (219 tests total: 183 pass, 35 fail, 1 skip — zero regressions).