Add autocomplete attrs to password/username fields #5143
Conversation
|
Which browsers emit warnings here? |
|
I think all Chromium browsers (Google Chrome, Microsoft Edge) do this:
https://www.chromium.org/developers/design-documents/create-amazing-password-forms/ |
|
What about this PR? Do we want to add the autocomplete attributes on the applicable inputs? |
| <.simple_form :let={f} for={:<%= schema.singular %>} id="resend_confirmation_form" phx-submit="send_instructions"> | ||
| <.input field={{f, :email}} type="email" label="Email" required /> | ||
| <.input field={{f, :email}} type="email" label="Email" autocomplete="username" required /> |
There was a problem hiding this comment.
Is there a reason why you are using autocomplete="username" rather than autocomplete="email" on the email fields?
There was a problem hiding this comment.
Not really, I think you're right and we should update this to autocomplete="email". I'm happy to do so and also bring this PR in sync with the master branch?
There was a problem hiding this comment.
That couldn't hurt. I'm not a maintainer myself, but I'd be keen to see it merged.
There was a problem hiding this comment.
Not really, I think you're right and we should update this to
autocomplete="email". I'm happy to do so and also bring this PR in sync with the master branch?
autocomplete="username" with type=“email” is correct as those are the attributes of the same field in other templates (e.g. registration). So with the current value the browser is advised to use the same value the user as entered before.
HTML spec allows the combination of type=“email” and autocomplete=username”.
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#control-group-username
Chromium advices the combi:
https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands/
There was a problem hiding this comment.
Thanks @BartOtten. I'll bring this PR up to date with master later this week.
|
Can you resolve conflicts? Note you will also need to ensure the update files are formatted properly as they likely will be broken into new lines. You can |
Yes, will do so in the beginning of next week! |
janwillemvd
force-pushed
the
add-autocomplete-attrs-for-inputs
branch
from
1c38720 to
6ba6a4b
Compare
Done! |
|
First of all, congrats with the great 0.20 release, @chrismccord! Do you think this PR is mergeable or do we mis something? |
|
Is there something which needs to be done to get this one merged? |
|
@janwillemvd I'm very sorry that this took so long! LGTM! Thank you very much! |
|
No worries, @SteffenDE. Thanks!! |
7 participants
Some browsers give console warnings if the
autocompleteattribute is missing on username/password fields.