Fix backup creation crashing on missing session data#177
Open
duncanplatt wants to merge 1 commit intophotodiode:masterfrom
Open
Fix backup creation crashing on missing session data#177duncanplatt wants to merge 1 commit intophotodiode:masterfrom
duncanplatt wants to merge 1 commit intophotodiode:masterfrom
Conversation
backup.create() crashes when a window has no groups in session storage
or a group has no stored rect, both of which can occur after Firefox 148
changed session data behavior (Bug 2002643). This broke both manual
"Save As" and automatic backups since ~January 2026.
- Add null check for groups from getWindowValue, skip windows with no
group data instead of crashing on groups.sort()
- Add fallback rect {x:0, y:0, w:0.5, h:0.5} when getGroupValue
returns undefined, matching the default used in view.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backup.create()crashes when a window has no groups stored in session data, or when a group has no storedrectvalue — both result in a TypeError on a null/undefined reference{x:0, y:0, w:0.5, h:0.5}(same default used inview.js) when a group has no stored positionTest plan