Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 24 24
Lines 1624 1624
=======================================
Hits 1537 1537
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. |
Collaborator
Author
|
@snk4tr ready for review |
|
Kudos, SonarCloud Quality Gate passed!
|
snk4tr
approved these changes
Jul 27, 2020
Contributor
snk4tr
left a comment
snk4tr
left a comment
There was a problem hiding this comment.
Thanks for doing that. Looks much leaner now 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152
Proposed Changes
py3.8testing into CIpy3.7lint validation