Add test for correct data range

[jzakirov]

Closes #194 and #196

Proposed Changes

• Test that values are always lower than data_range
• Test that results is consistent for different data ranges

Progres

• BRISQUE
• FSIM
• GMSD
• HaarPSI
• MDSI
• PSNR
• SSIM
• VIF
• VSI
• PieAPP

[codecov]

Codecov Report

Merging #195 (65cf43d) into master (5ee4839) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   95.32%   95.34%   +0.01%     
==========================================
  Files          26       26              
  Lines        1777     1784       +7     
==========================================
+ Hits         1694     1701       +7     
  Misses         83       83              

Flag	Coverage Δ
unittests	95.34% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
piq/brisque.py	99.02% <100.00%> (-0.01%)	⬇️
piq/fsim.py	100.00% <100.00%> (ø)
piq/functional/colour_conversion.py	100.00% <100.00%> (ø)
piq/gmsd.py	100.00% <100.00%> (ø)
piq/haarpsi.py	100.00% <100.00%> (ø)
piq/mdsi.py	100.00% <100.00%> (ø)
piq/pieapp.py	100.00% <100.00%> (ø)
piq/psnr.py	83.33% <100.00%> (ø)
piq/ssim.py	100.00% <100.00%> (ø)
piq/utils/common.py	100.00% <100.00%> (ø)
... and 2 more

[jzakirov]

Let's merge this first, then #184

[snk4tr]

Let's merge this first, then #184

Well, I think I missed this one. #184 is already merged. Is it a problem?
@zakajd do you need to add something now (probably one more test from the PieAPP metric) to make this PR complete?

[jzakirov]

Yes, I need to add data range tests to PieAPP before merge.
Will do it tomorrow and merge if you don't have any additional questions

[snk4tr]

Yes, I need to add data range tests to PieAPP before merge.
Will do it tomorrow and merge if you don't have any additional questions

I will add my review now and revise tomorrow evening after the data range tests for the PieAPP will be added. Then we can merge 😄

[snk4tr]

I like the PR a lot. Only small remarks from my side.

[snk4tr]

General remark to all the series of tests: could you add more options of the data_range values if it is not too computationally heavy? It would be very interesting to see what happens if data_range is 1.0, <1.0 (for instance 0.5) of some weird huge number like 3000.

[jzakirov]

@snk4tr Ready to be merged

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication