Access modifiers for feature extraction methods#204
Merged
Conversation
…ix readme and docstrings Signed-off-by: Sergey Kastryulin <snk4tr@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 26 26
Lines 1777 1777
=======================================
Hits 1694 1694
Misses 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. |
jzakirov
approved these changes
Jan 14, 2021
Collaborator
jzakirov
left a comment
jzakirov
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for also fixing small typos in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature extraction method for feature-based metrics used protected notation even though it was used publicly. Changed that and corresponding documentation and docstrings.
Closes #193
Proposed Changes