Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 95.35% 95.33% -0.02%
==========================================
Files 26 26
Lines 1785 1780 -5
==========================================
- Hits 1702 1697 -5
Misses 83 83
Flags with carried forward coverage won't be shown. Click here to find out more.
|
snk4tr
approved these changes
Jan 20, 2021
Contributor
snk4tr
left a comment
snk4tr
left a comment
There was a problem hiding this comment.
Nice one, @zakajd! Feel free to merge.
However, I noticed that you changed the version of the package. Please make sure to add new tag and release notes. I can do that as well if you lack time.
Collaborator
Author
|
@snk4tr Yes, please create tag and release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #208
Proposed Changes
predictionandtargetnames.After fix I got
PIQ VIFp SRCC 0.6102, KRCC 0.4579
Paper values are SRCC 0.610 KRCC 0.457
Exact match!