Skip to content

Benchmark metrics on PIPAL dataset#269

Merged
jzakirov merged 4 commits intomasterfrom
feature/benchmark-pipal
Sep 6, 2021
Merged

Benchmark metrics on PIPAL dataset#269
jzakirov merged 4 commits intomasterfrom
feature/benchmark-pipal

Conversation

@jzakirov
Copy link
Collaborator

@jzakirov jzakirov commented Sep 2, 2021

Closes #239

Proposed Changes

  • Add support for benchmarking on PIPAL dataset
  • Update columns to metrics table with results on PIPAL
  • Delete rows corresponding to IW-SSIM and IW-PSNR metrics, because they are not yet implemented
  • Reduce precision to 3 digits.

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #269 (79ce3f3) into master (c1be151) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   95.90%   95.79%   -0.11%     
==========================================
  Files          31       31              
  Lines        1952     1952              
==========================================
- Hits         1872     1870       -2     
- Misses         80       82       +2     
Flag Coverage Δ
unittests 95.79% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/gs.py 89.88% <0.00%> (-2.25%) ⬇️

@snk4tr snk4tr added the enhancement Making some part of the codebase better without introduction of new features label Sep 3, 2021
@jzakirov jzakirov requested a review from denproc September 3, 2021 09:31
@jzakirov
Copy link
Collaborator Author

jzakirov commented Sep 3, 2021

Ready for review

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@snk4tr snk4tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @denproc what do you think?
@zakajd feel free to merge when ready.

@jzakirov jzakirov merged commit 35e504d into master Sep 6, 2021
@snk4tr snk4tr deleted the feature/benchmark-pipal branch September 8, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Making some part of the codebase better without introduction of new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Benchmark metrics on PIPAL dataset

2 participants