Skip to content

Fix of the PyTorch version parser#290

Merged
jzakirov merged 3 commits intomasterfrom
fix/version-parsing-2
Feb 6, 2022
Merged

Fix of the PyTorch version parser#290
jzakirov merged 3 commits intomasterfrom
fix/version-parsing-2

Conversation

@snk4tr
Copy link
Contributor

@snk4tr snk4tr commented Feb 4, 2022

Closes #289

Proposed Changes

Signed-off-by: Sergey Kastryulin <snk4tr@gmail.com>
@snk4tr snk4tr added the bug Something isn't working label Feb 4, 2022
@snk4tr snk4tr requested a review from jzakirov February 4, 2022 10:02
@snk4tr snk4tr self-assigned this Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #290 (6cca07e) into master (e8f6513) will decrease coverage by 2.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   93.25%   91.00%   -2.26%     
==========================================
  Files          33       33              
  Lines        2283     2289       +6     
==========================================
- Hits         2129     2083      -46     
- Misses        154      206      +52     
Flag Coverage Δ
unittests 91.00% <100.00%> (-2.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/utils/common.py 93.75% <100.00%> (+0.89%) ⬆️
piq/gs.py 32.96% <0.00%> (-57.15%) ⬇️

Signed-off-by: Sergey Kastryulin <snk4tr@gmail.com>
Signed-off-by: Sergey Kastryulin <snk4tr@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@snk4tr
Copy link
Contributor Author

snk4tr commented Feb 4, 2022

@zakajd ready for review.

Copy link
Collaborator

@jzakirov jzakirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix!
LGTM 👍🏼

@jzakirov jzakirov merged commit 6e06c80 into master Feb 6, 2022
@snk4tr snk4tr deleted the fix/version-parsing-2 branch February 7, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in __version_tuple function

2 participants