Skip to content

GPU-based IW-SSIM processing #311

Merged
snk4tr merged 4 commits intomasterfrom
bug/iw_ssim
Apr 18, 2022
Merged

GPU-based IW-SSIM processing #311
snk4tr merged 4 commits intomasterfrom
bug/iw_ssim

Conversation

@denproc
Copy link
Collaborator

@denproc denproc commented Apr 2, 2022

Closes #310

Proposed Changes

  • Add torch version handler
  • Eliminate torch==1.8.* and torchvision==0.9.* from requirements
  • In case of torch==1.9.* and torchvision==0.10.* use torch.symeig instead of torch.linalg.eigh
  • Tested on GPU

@denproc denproc added the bug Something isn't working label Apr 2, 2022
@denproc denproc requested review from jzakirov and snk4tr April 2, 2022 16:28
@denproc denproc self-assigned this Apr 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #311 (b196b8b) into master (9da71aa) will increase coverage by 2.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   91.87%   94.12%   +2.25%     
==========================================
  Files          34       34              
  Lines        2486     2486              
==========================================
+ Hits         2284     2340      +56     
+ Misses        202      146      -56     
Flag Coverage Δ
unittests 94.12% <100.00%> (+2.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/iw_ssim.py 100.00% <100.00%> (ø)
piq/feature_extractors/fid_inception.py 99.23% <0.00%> (+1.53%) ⬆️
piq/gs.py 92.30% <0.00%> (+59.34%) ⬆️

@denproc denproc changed the title Bug/iw ssim GPU-based IW-SSIM processing Apr 2, 2022
Copy link
Collaborator

@jzakirov jzakirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@snk4tr snk4tr merged commit 51d7633 into master Apr 18, 2022
@snk4tr snk4tr deleted the bug/iw_ssim branch April 18, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feasibility of computation of IW-SSIM on CUDA

3 participants