Skip to content

Batch-wise computation of features for feature-based metrics#325

Merged
jzakirov merged 2 commits intomasterfrom
fix-feats-gpu-memory
Jan 19, 2023
Merged

Batch-wise computation of features for feature-based metrics#325
jzakirov merged 2 commits intomasterfrom
fix-feats-gpu-memory

Conversation

@snk4tr
Copy link
Contributor

@snk4tr snk4tr commented Dec 18, 2022

Closes #214

Proposed Changes

  • Batch-wise computation of features for feature-based metrics
  • Invoke CUDA empty cache to de-allocate GPU memory after features computation
  • Add some files to .gitignore

@snk4tr snk4tr added the bug Something isn't working label Dec 18, 2022
@snk4tr snk4tr requested review from denproc and jzakirov December 18, 2022 16:00
@snk4tr snk4tr self-assigned this Dec 18, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@denproc denproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes: LGTM.
Github Pipelines: :(

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #325 (64daca1) into master (27db4f3) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   91.50%   91.96%   +0.45%     
==========================================
  Files          34       34              
  Lines        2485     2490       +5     
==========================================
+ Hits         2274     2290      +16     
+ Misses        211      200      -11     
Flag Coverage Δ
unittests 91.96% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/base.py 90.32% <100.00%> (+1.86%) ⬆️
piq/iw_ssim.py 100.00% <0.00%> (+0.50%) ⬆️
piq/vsi.py 100.00% <0.00%> (+2.02%) ⬆️
piq/fsim.py 100.00% <0.00%> (+2.89%) ⬆️
piq/srsim.py 99.00% <0.00%> (+3.96%) ⬆️

Copy link
Collaborator

@jzakirov jzakirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@jzakirov jzakirov merged commit 26e088b into master Jan 19, 2023
@denproc denproc deleted the fix-feats-gpu-memory branch April 3, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential bug: Huge memory consumption in KID

3 participants